Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitor task: add timeout for monitor task, and support killing #247

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

superstar54
Copy link
Member

@superstar54 superstar54 commented Aug 21, 2024

Add timeout input for monitor task.

Support killing the monitor task manually:

  • Add kill action to the WorkGraph engine.
  • Add workgraph task kill command.

@superstar54 superstar54 linked an issue Aug 21, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 91.39785% with 8 lines in your changes missing coverage. Please review.

Project coverage is 79.99%. Comparing base (5937b88) to head (8b06867).
Report is 40 commits behind head on main.

Files Patch % Lines
aiida_workgraph/utils/control.py 71.42% 4 Missing ⚠️
aiida_workgraph/engine/workgraph.py 93.54% 2 Missing ⚠️
aiida_workgraph/workgraph.py 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #247      +/-   ##
==========================================
+ Coverage   75.75%   79.99%   +4.24%     
==========================================
  Files          70       65       -5     
  Lines        4615     4864     +249     
==========================================
+ Hits         3496     3891     +395     
+ Misses       1119      973     -146     
Flag Coverage Δ
python-3.11 79.91% <91.39%> (+4.24%) ⬆️
python-3.12 79.91% <91.39%> (?)
python-3.9 79.95% <91.39%> (+4.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superstar54 superstar54 merged commit 130e213 into main Aug 21, 2024
8 checks passed
@superstar54 superstar54 deleted the feature/monitor_timeout branch August 23, 2024 01:09
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support killing monitor task
2 participants