Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PickledFunction.build_executor #270

Merged
merged 1 commit into from
Aug 25, 2024

Conversation

superstar54
Copy link
Member

@superstar54 superstar54 commented Aug 25, 2024

Fix #269 .

Add a classmethod build_executor for class PickledFunction so that the decorator does not need to load AiiDA profile.

@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.74%. Comparing base (5937b88) to head (9ed7f6b).
Report is 49 commits behind head on main.

Files Patch % Lines
aiida_workgraph/orm/function_data.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #270      +/-   ##
==========================================
+ Coverage   75.75%   79.74%   +3.98%     
==========================================
  Files          70       65       -5     
  Lines        4615     4897     +282     
==========================================
+ Hits         3496     3905     +409     
+ Misses       1119      992     -127     
Flag Coverage Δ
python-3.11 79.66% <90.90%> (+3.99%) ⬆️
python-3.12 79.64% <90.90%> (?)
python-3.9 79.67% <90.90%> (+3.94%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superstar54 superstar54 force-pushed the fix/269/use_non_aiida_node_for_executor branch from 6cbf441 to 4cbf3c7 Compare August 25, 2024 10:43
@superstar54 superstar54 changed the title Use PickledFunction.serialize_function in decorator Add PickledFunction.build_executor Aug 25, 2024
@superstar54 superstar54 force-pushed the fix/269/use_non_aiida_node_for_executor branch from 4cbf3c7 to 9ed7f6b Compare August 25, 2024 10:55
@superstar54 superstar54 merged commit 70bf8f9 into main Aug 25, 2024
8 checks passed
@superstar54 superstar54 deleted the fix/269/use_non_aiida_node_for_executor branch August 25, 2024 12:37
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need load_profile when using decorator
2 participants