Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle empty zone #272

Merged
merged 2 commits into from
Aug 26, 2024
Merged

handle empty zone #272

merged 2 commits into from
Aug 26, 2024

Conversation

superstar54
Copy link
Member

@superstar54 superstar54 commented Aug 26, 2024

If a zone has no child, set it to finish immediately.

@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 92.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.72%. Comparing base (5937b88) to head (f28be4f).
Report is 54 commits behind head on main.

Files Patch % Lines
aiida_workgraph/engine/workgraph.py 90.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #272      +/-   ##
==========================================
+ Coverage   75.75%   79.72%   +3.97%     
==========================================
  Files          70       65       -5     
  Lines        4615     4908     +293     
==========================================
+ Hits         3496     3913     +417     
+ Misses       1119      995     -124     
Flag Coverage Δ
python-3.11 79.64% <92.00%> (+3.97%) ⬆️
python-3.12 79.64% <92.00%> (?)
python-3.9 79.68% <92.00%> (+3.94%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superstar54 superstar54 merged commit 59ab042 into main Aug 26, 2024
7 of 8 checks passed
@superstar54 superstar54 deleted the fix/271/empty_zone branch August 26, 2024 11:03
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinite run if the zone (if, while) is empty, i.e., there is not child.
2 participants