-
-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proxy not working due to signature mismatch #1070
Comments
oh man quite a bit of work (and research) is needed here. Going to take a bit to get to. Welcome to PRs! |
That's what it also looked like to me... |
probably my fault, or bit rot |
Do we even need According to aiohttp documentation:
Maybe we should think about ways to merge both TLS configurations into a single SSLContext? |
Description
The method
_setup_proxy_ssl_context
expects a string but is passed a dict here. At theparse_url()
call, the connection establishment will fail as the dict cannot be parsed as url and does not even contain the url (which is why I can't think of an easy fix right now).In commit fbfeb1242ab1f378f6d4fe84b5d3dacdd8874189, the signature was changed but the call was not updated. Reverting the changes applied to
_setup_proxy_ssl_context
does solve the problem.In botocore,
_setup_proxy_ssl_context
is called in thesend
method where the request is available.Checklist
pip check
passes without errorspip freeze
resultstriedreviewed the same code in botocore to ensure this is an aiobotocore specific issuetriedreviewed similar code in aiohttp to ensure this is is an aiobotocore specific issuepip freeze results
Environment:
The text was updated successfully, but these errors were encountered: