Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump minimum aiohttp req, drop python 3.7, add aiohttp version tests #1033

Merged
merged 10 commits into from
Aug 11, 2023

Conversation

thehesiod
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #1033 (8d9036a) into master (0a93fb8) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

❗ Current head 8d9036a differs from pull request most recent head 109db2b. Consider uploading reports for the commit 109db2b to get more accurate results

@@            Coverage Diff             @@
##           master    #1033      +/-   ##
==========================================
- Coverage   86.27%   86.14%   -0.13%     
==========================================
  Files          58       58              
  Lines        5747     5740       -7     
==========================================
- Hits         4958     4945      -13     
- Misses        789      795       +6     
Flag Coverage Δ
unittests 86.14% <100.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
aiobotocore/response.py 76.00% <ø> (ø)
tests/test_version.py 97.16% <ø> (ø)
tests/test_patches.py 95.91% <100.00%> (-0.31%) ⬇️

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@thehesiod thehesiod merged commit 2b0bd95 into master Aug 11, 2023
6 checks passed
@thehesiod thehesiod deleted the thehesiod/testing branch August 11, 2023 20:36
@thehesiod thehesiod changed the title bump minimum aiohttp req and add aiohttp tests bump minimum aiohttp req, drop python 3.7, add aiohttp version tests Aug 11, 2023
Comment on lines -122 to -125
ClientResponse: {
'e178726065b609c69a1c02e8bb78f22efce90792',
'225e8033bfcff8cccbc2e975d7bd0c7993f14366',
},
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is no longer needed as we don't reach into the private members anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant