Remove confusing aiobotocore.session.Session symbol
#1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakob-keller
force-pushed
the
session
branch
2 times, most recently
from
9168bb1
to
d9729f3
Compare
Codecov Report
@@ Coverage Diff @@
## master #1047 +/- ##
=======================================
Coverage 86.39% 86.39%
=======================================
Files 60 60
Lines 5805 5807 +2
=======================================
+ Hits 5015 5017 +2
Misses 790 790
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
thehesiod
approved these changes
Oct 23, 2023
|
hrm, github resolve isn't so great |
|
feel free to re-merge and force push up |
CI is running 🤞🏻 |
BREAKING-CHANGE: replace any use of `aiobotocore.session.Session` by `botocore.session.Session`
auto-merge was automatically disabled
October 24, 2023 14:48
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Rename import of
botocore.session.Sessioninaiobotocore.sessionto mark it private.Assumptions
aiobotocore.session.Sessionwas never intended to become part of public API.Checklist for All Submissions