Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support up-to-date botocore #1063

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Conversation

jakob-keller
Copy link
Collaborator

@jakob-keller jakob-keller commented Dec 5, 2023

Description of Change

This PR intends to improve general compatibility of aiobotocore within the Python ecosystem by bumping the dependency specification of botocore, as well as boto3 and awscli.

It also restores feature parity with respect to recently released and improved AWS services, in particular adding support for S3 Express One Zone.

Assumptions

Upstream diff contains multiple changes that affect this codebase.

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details): closes Support botocore>=1.33.2 #1065
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

@jakob-keller jakob-keller force-pushed the bump-botocore branch 2 times, most recently from f5895b6 to 600af7f Compare December 5, 2023 19:39
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (1ce6853) 86.46% compared to head (ef378b7) 86.13%.

Files Patch % Lines
aiobotocore/utils.py 45.16% 17 Missing ⚠️
aiobotocore/signers.py 58.33% 5 Missing ⚠️
aiobotocore/client.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1063      +/-   ##
==========================================
- Coverage   86.46%   86.13%   -0.34%     
==========================================
  Files          60       60              
  Lines        5814     5863      +49     
==========================================
+ Hits         5027     5050      +23     
- Misses        787      813      +26     
Flag Coverage Δ
unittests 86.13% <58.92%> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakob-keller jakob-keller force-pushed the bump-botocore branch 2 times, most recently from 29e1a76 to 8e7c2bc Compare December 5, 2023 22:35
@jakob-keller jakob-keller marked this pull request as ready for review December 5, 2023 22:54
@jakob-keller
Copy link
Collaborator Author

jakob-keller commented Dec 5, 2023

@thehesiod: Another bump that adds support for new AWS services and features.

I'm unsure how to deal with the lack of test coverage. Is this something to be concerned about?

@thehesiod
Copy link
Collaborator

@thehesiod: Another bump that adds support for new AWS services and features.

I'm unsure how to deal with the lack of test coverage. Is this something to be concerned about?

not reaaaly, bonus if they're added. We should probably have a task to port all the botocore tests over

@thehesiod
Copy link
Collaborator

will get to this today

@jakob-keller
Copy link
Collaborator Author

will get to this today

I just pushed another update that extends compatibility up to yesterday's botocore release. It's all yours now ;-)

@thehesiod
Copy link
Collaborator

whoops didn't get to it. will do asap

setup.py Show resolved Hide resolved
setup.py Show resolved Hide resolved
@thehesiod thehesiod merged commit 110b0a2 into aio-libs:master Dec 13, 2023
10 of 11 checks passed
@thehesiod
Copy link
Collaborator

going to do version w/o prefix this time, see how it goes

@thehesiod
Copy link
Collaborator

thanks for all the help!

@jakob-keller jakob-keller deleted the bump-botocore branch December 13, 2023 07:47
@thehesiod
Copy link
Collaborator

I liked your strategy of supporting multiple botocore versions, probably worth adding to the docs describing how to do upgrades

@thehesiod
Copy link
Collaborator

actually was thinking about this last night, we can probably add a python helper where you set a base revision, and it tells you which ranges have only service json changes. Would save a lot of manual labor.

@jakob-keller
Copy link
Collaborator Author

we can probably add a python helper where you set a base revision, and it tells you which ranges have only service json changes.

That's true. To reach the next level of automation, it would be nice to run a scheduled GitHub action that checks for new botocore releases and opens PRs, if these are light-weight, i.e. only contain service JSON updates. Once that is stable, these PRs could even be auto-merged after passing CI. Eventually, we could also do automated minor releases.

@thehesiod
Copy link
Collaborator

i like your thinking :]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support botocore>=1.33.2
2 participants