Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize build configuration #1160

Merged
merged 4 commits into from
Aug 21, 2024

Conversation

jakob-keller
Copy link
Collaborator

@jakob-keller jakob-keller commented Aug 20, 2024

Description of Change

  • remove outdated MANIFEST.in -> gets rid of build warnings
  • remove arguments include_package_data and packages to setup() -> gets rid of build issues around retries sub-package
  • add PEP 517 / PEP 518 compatible [build-system] table to pyproject.toml
  • add PEP 621 compatible [project] table to pyproject.toml and merge contents of setup.py into it
  • update relevant documentation and unit tests

Assumptions

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details):
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

@jakob-keller jakob-keller added enhancement New feature or request dependencies Pull requests that update a dependency file labels Aug 20, 2024
@jakob-keller jakob-keller self-assigned this Aug 20, 2024
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.98%. Comparing base (2d9857b) to head (0d06dd2).
Report is 5 commits behind head on master.

Files Patch % Lines
tests/test_version.py 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1160      +/-   ##
==========================================
- Coverage   87.03%   86.98%   -0.05%     
==========================================
  Files          64       64              
  Lines        5969     5978       +9     
==========================================
+ Hits         5195     5200       +5     
- Misses        774      778       +4     
Flag Coverage Δ
unittests 86.98% <93.75%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thehesiod
Copy link
Collaborator

I think setuptools is going away no? I remember now using the build module

@jakob-keller
Copy link
Collaborator Author

jakob-keller commented Aug 20, 2024

Not really: setuptools is still fully supported and maintained - as a build backend, just not as a build tool. build is a build tool that support any compatible backend. The two work hand in hand.

I am working on modernizing our build and packaging setup, which will include switching the build tool to build, while keeping setuptools as backend, at least for now. Once that setup is modernised, it will be a lot easier to switch build backends and/or tools if we decide to do so.

@jakob-keller jakob-keller force-pushed the modern-packaging branch 3 times, most recently from d9f2725 to bd8e300 Compare August 20, 2024 21:52
@jakob-keller jakob-keller changed the title Modernize packaging Modernize build configuration Aug 20, 2024
@jakob-keller jakob-keller marked this pull request as ready for review August 20, 2024 22:15
docs/conf.py Outdated Show resolved Hide resolved
aiobotocore/__init__.py Outdated Show resolved Hide resolved
MANIFEST.in Outdated Show resolved Hide resolved
requirements-dev.in Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
setup.py Show resolved Hide resolved
setup.py Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@jakob-keller jakob-keller merged commit d80e20d into aio-libs:master Aug 21, 2024
11 checks passed
@jakob-keller jakob-keller deleted the modern-packaging branch August 21, 2024 08:15
@jakob-keller
Copy link
Collaborator Author

Thank you for reviewing, @thehesiod & @webknjaz!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants