Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Await call to async method AioAssumeRoleProvider._load_creds_via_assu… #858

Merged
merged 2 commits into from
Mar 11, 2021

Conversation

puzza007
Copy link
Contributor

@puzza007 puzza007 commented Mar 11, 2021

Fixes #854

Description of Change

Fix async method call which wasn't awaited and results in

    frozen_credentials = await self._source_credentials.get_frozen_credentials()
AttributeError: 'coroutine' object has no attribute 'get_frozen_credentials'

Assumptions

Replace this text with any assumptions made (if any)

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details):
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

@thehesiod
Copy link
Collaborator

thank you! want to add this to changes with a new dot release?

@puzza007
Copy link
Contributor Author

Sure! Bumped version and added change to CHANGES.rst

@thehesiod
Copy link
Collaborator

I'm trying to see if I can find a test to catch this, if you can spot it in botocore lemme know so we can port over

@thehesiod
Copy link
Collaborator

found it test_recursive_assume_role, now to see the best/easiest way to port it

@thehesiod thehesiod merged commit f629456 into aio-libs:master Mar 11, 2021
@puzza007 puzza007 deleted the issue_854 branch March 11, 2021 07:06
@puzza007
Copy link
Contributor Author

Beat me to it - thanks!

@thehesiod
Copy link
Collaborator

test in #859

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: 'coroutine' object has no attribute 'get_frozen_credentials'
2 participants