Use pessimistic mode for reference many delete (#760)

aio-libs · Jul 31, 2023 · 0ee079b · 0ee079b
1 parent ade847c
commit 0ee079b
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/admin-js/src/App.js b/admin-js/src/App.js
@@ -59,6 +59,8 @@ const DatagridSingle = (props) => (
 const COMPONENTS = {
     Datagrid, DatagridSingle,
 
+    BulkDeleteButton,
+
     BooleanField, DateField, NumberField, ReferenceField, ReferenceManyField,
     ReferenceOneField, SelectField, TextField, TimeField,
 

diff --git a/aiohttp_admin/backends/sqlalchemy.py b/aiohttp_admin/backends/sqlalchemy.py
@@ -229,6 +229,9 @@ def __init__(self, db: AsyncEngine, model_or_table: Union[sa.Table, type[Declara
                     children.append(comp(field, c_props))
                 container = "Datagrid" if t == "ReferenceManyField" else "DatagridSingle"
                 datagrid = comp(container, {"children": children, "rowClick": "show"})
+                if t == "ReferenceManyField":
+                    datagrid["props"]["bulkActionButtons"] = comp(
+                        "BulkDeleteButton", {"mutationMode": "pessimistic"})
                 props["children"] = (datagrid,)
 
                 self.fields[name] = comp(t, props)

diff --git a/tests/test_backends_sqlalchemy.py b/tests/test_backends_sqlalchemy.py
@@ -146,7 +146,8 @@ class TestOne(base):  # type: ignore[misc,valid-type]
     assert r.fields["ones"] == comp(
         "ReferenceManyField",
         {"children": (comp("Datagrid", {
-            "rowClick": "show", "children": [comp("NumberField", {"source": "id"})]}),),
+            "rowClick": "show", "children": [comp("NumberField", {"source": "id"})],
+            "bulkActionButtons": comp("BulkDeleteButton", {"mutationMode": "pessimistic"})}),),
          "label": "Ones", "reference": "one", "source": "id", "target": "many_id",
          "sortable": False})
     assert "ones" not in r.inputs