-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test_proxy_from_env did not clear proxies already set in the #5557
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5557 +/- ##
=======================================
Coverage 97.21% 97.21%
=======================================
Files 41 41
Lines 8863 8863
Branches 1425 1425
=======================================
Hits 8616 8616
Misses 130 130
Partials 117 117
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
environment. Added code to first clear proxies that were already set. Refactored the parametrize input on test_proxy_from_env to work more like test_get_env_proxy_for_url to be consistent.
bfa01ab
to
964a427
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Backport to 3.8: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply bb4ee18 on top of patchback/backports/3.8/bb4ee18d69eacfcd8333497b0c7b2a108f09e546/pr-5557 Backporting merged PR #5557 into master
🤖 @patchback |
💔 Backport was not successfulThe PR was attempted backported to the following branches:
|
As you can see, backporting is not easy. |
Backport PR: #6184 |
…roxies already set in the (#6184) Co-authored-by: Steve Cirelli <scirelli+git@gmail.com>
What do these changes do?
Fix failing tests when a environment proxy is set.
test_proxy_from_env did not clear proxies already set in the environment. Added code to first clear proxies that were already set.
Refactored the parametrize input on test_proxy_from_env to work more like test_get_env_proxy_for_url to be consistent.
Are there changes in behavior for the user?
No.
Related issue number
#5554
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.