[doc] clarify ClientTimeout behavior #6683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
be clear that the 5 second timeout is also rounded. see: https://github.com/aio-libs/aiohttp/blob/master/aiohttp/helpers.py#L638
Dreamsorcerer
added
bot:chronographer:skip
Co-authored-by: Sam Bull <aa6bs0@sambull.org>
Codecov Report
@@ Coverage Diff @@
## master #6683 +/- ##
=======================================
Coverage 93.36% 93.36%
=======================================
Files 104 104
Lines 30628 30628
Branches 3077 3077
=======================================
Hits 28596 28596
Misses 1859 1859
Partials 173 173
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Backport to 3.8: 💚 backport PR created✅ Backport PR branch: Backported as #6684 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Apr 9, 2022
* [doc] clarify ClientTimeout behavior be clear that the 5 second timeout is also rounded. see: https://github.com/aio-libs/aiohttp/blob/master/aiohttp/helpers.py#L638 * Update docs/client_reference.rst Co-authored-by: Sam Bull <aa6bs0@sambull.org> Co-authored-by: Sam Bull <aa6bs0@sambull.org> (cherry picked from commit 90964d0)
Backport to 3.9: 💚 backport PR created✅ Backport PR branch: Backported as #6685 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Apr 9, 2022
* [doc] clarify ClientTimeout behavior be clear that the 5 second timeout is also rounded. see: https://github.com/aio-libs/aiohttp/blob/master/aiohttp/helpers.py#L638 * Update docs/client_reference.rst Co-authored-by: Sam Bull <aa6bs0@sambull.org> Co-authored-by: Sam Bull <aa6bs0@sambull.org> (cherry picked from commit 90964d0)
Dreamsorcerer
pushed a commit
that referenced
this pull request
Apr 10, 2022
* [doc] clarify ClientTimeout behavior be clear that the 5 second timeout is also rounded. see: https://github.com/aio-libs/aiohttp/blob/master/aiohttp/helpers.py#L638 * Update docs/client_reference.rst Co-authored-by: Sam Bull <aa6bs0@sambull.org> Co-authored-by: Sam Bull <aa6bs0@sambull.org> (cherry picked from commit 90964d0) Co-authored-by: Rafael Stahl <dummdoof-doof@web.de>
Dreamsorcerer
added a commit
that referenced
this pull request
Apr 10, 2022
#6684) * [doc] clarify ClientTimeout behavior (#6683) * [doc] clarify ClientTimeout behavior be clear that the 5 second timeout is also rounded. see: https://github.com/aio-libs/aiohttp/blob/master/aiohttp/helpers.py#L638 * Update docs/client_reference.rst Co-authored-by: Sam Bull <aa6bs0@sambull.org> Co-authored-by: Sam Bull <aa6bs0@sambull.org> (cherry picked from commit 90964d0) * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: Rafael Stahl <dummdoof-doof@web.de> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Sam Bull <aa6bs0@sambull.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Be clear that the 5 second timeout is also rounded. see: https://github.com/aio-libs/aiohttp/blob/master/aiohttp/helpers.py#L638
Are there changes in behavior for the user?
No