Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix usage of proxy.py in test_proxy_functional (#7773) #7877

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 23, 2023

(cherry picked from commit 4d9fc63)

@bdraco bdraco marked this pull request as draft November 23, 2023 12:47
@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Nov 23, 2023
@bdraco
Copy link
Member Author

bdraco commented Nov 23, 2023

still need to test locally before undrafting

@bdraco
Copy link
Member Author

bdraco commented Nov 23, 2023

Results (4.59s):
19 passed
3 skipped

@bdraco bdraco marked this pull request as ready for review November 23, 2023 12:48
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3c63ca0) 97.34% compared to head (ee451da) 97.34%.
Report is 1 commits behind head on 3.10.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.10    #7877   +/-   ##
=======================================
  Coverage   97.34%   97.34%           
=======================================
  Files         108      108           
  Lines       32384    32402   +18     
  Branches     3839     3842    +3     
=======================================
+ Hits        31524    31542   +18     
  Misses        655      655           
  Partials      205      205           
Flag Coverage Δ
CI-GHA 97.25% <100.00%> (+<0.01%) ⬆️
OS-Linux 96.94% <100.00%> (+<0.01%) ⬆️
OS-Windows 94.44% <100.00%> (-0.06%) ⬇️
OS-macOS 96.75% <100.00%> (+0.14%) ⬆️
Py-3.10.11 94.34% <100.00%> (-0.07%) ⬇️
Py-3.10.13 96.72% <100.00%> (-0.06%) ⬇️
Py-3.11.6 96.48% <100.00%> (+0.03%) ⬆️
Py-3.12.0 96.38% <100.00%> (?)
Py-3.8.10 94.31% <100.00%> (-0.07%) ⬇️
Py-3.8.18 96.65% <100.00%> (-0.06%) ⬇️
Py-3.9.13 94.33% <100.00%> (-0.06%) ⬇️
Py-3.9.18 96.70% <100.00%> (-0.06%) ⬇️
Py-pypy7.3.13 96.16% <100.00%> (-0.06%) ⬇️
VM-macos 96.75% <100.00%> (+0.14%) ⬆️
VM-ubuntu 96.94% <100.00%> (+<0.01%) ⬆️
VM-windows 94.44% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer merged commit a5e8aba into aio-libs:3.10 Nov 23, 2023
28 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants