Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #7808/213d1b2 backport][3.9] Restore requirements-txt-fixer in pre-commit #7920

Merged
merged 1 commit into from
Nov 29, 2023
Merged

[PR #7808/213d1b2 backport][3.9] Restore requirements-txt-fixer in pre-commit #7920

merged 1 commit into from
Nov 29, 2023

Conversation

alexrudd2
Copy link
Contributor

@alexrudd2 alexrudd2 commented Nov 28, 2023

Backport of #7808 cherry picked from commit 213d1b2

What do these changes do?

Repair a useless pre-commit hook, since requirements.txt was removed in #6165

This can be verified with pre-commit run --all-files.

Are there changes in behavior for the user?

No

@alexrudd2
Copy link
Contributor Author

@Dreamsorcerer

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0bc17e6) 97.13% compared to head (0eb99b4) 97.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##              3.9    #7920      +/-   ##
==========================================
+ Coverage   97.13%   97.35%   +0.21%     
==========================================
  Files         108      108              
  Lines       32459    32459              
  Branches     3133     3849     +716     
==========================================
+ Hits        31529    31600      +71     
+ Misses        710      655      -55     
+ Partials      220      204      -16     
Flag Coverage Δ
CI-GHA 97.26% <ø> (+0.18%) ⬆️
OS-Linux 96.95% <ø> (+0.16%) ⬆️
OS-Windows 94.45% <ø> (ø)
OS-macOS 96.76% <ø> (?)
Py-3.10.11 94.35% <ø> (ø)
Py-3.10.13 96.73% <ø> (+0.04%) ⬆️
Py-3.11.6 96.45% <ø> (?)
Py-3.12.0 96.39% <ø> (?)
Py-3.8.10 94.33% <ø> (+<0.01%) ⬆️
Py-3.8.18 96.66% <ø> (ø)
Py-3.9.13 94.34% <ø> (-0.01%) ⬇️
Py-3.9.18 96.71% <ø> (+0.03%) ⬆️
Py-pypy7.3.13 96.17% <ø> (?)
VM-macos 96.76% <ø> (?)
VM-ubuntu 96.95% <ø> (+0.16%) ⬆️
VM-windows 94.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexrudd2 alexrudd2 changed the title Restore requirements-txt-fixer in pre-commit (#7808) [PR #7808/213d1b2 backport][3.9] Restore requirements-txt-fixer in pre-commit Nov 28, 2023
@Dreamsorcerer Dreamsorcerer added the bot:chronographer:skip This PR does not need to include a change note label Nov 29, 2023
@Dreamsorcerer Dreamsorcerer merged commit ee8f7bf into aio-libs:3.9 Nov 29, 2023
27 of 31 checks passed
@alexrudd2 alexrudd2 deleted the patchback/backports/3.9/213d1b22d42ce8efc54d7858b490e920fcdb4f0a/pr-7808 branch November 30, 2023 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants