Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement happy eyeballs (RFC 8305) (#7954) #8005

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jan 5, 2024

(cherry picked from commit c4ec3f1)

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jan 5, 2024
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (8222403) 97.37% compared to head (3b291d0) 97.37%.
Report is 9 commits behind head on 3.10.

Files Patch % Lines
aiohttp/connector.py 91.66% 2 Missing and 1 partial ⚠️
tests/test_connector.py 99.22% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             3.10    #8005    +/-   ##
========================================
  Coverage   97.37%   97.37%            
========================================
  Files         108      108            
  Lines       32541    32735   +194     
  Branches     3847     3894    +47     
========================================
+ Hits        31687    31876   +189     
- Misses        652      656     +4     
- Partials      202      203     +1     
Flag Coverage Δ
CI-GHA 97.28% <98.50%> (+<0.01%) ⬆️
OS-Linux 96.98% <98.50%> (+<0.01%) ⬆️
OS-Windows 94.48% <96.88%> (+<0.01%) ⬆️
OS-macOS 96.80% <98.50%> (+0.20%) ⬆️
Py-3.10.11 94.38% <96.88%> (+<0.01%) ⬆️
Py-3.10.13 96.76% <98.50%> (+<0.01%) ⬆️
Py-3.11.7 96.52% <98.50%> (+0.03%) ⬆️
Py-3.12.1 96.54% <98.50%> (+<0.01%) ⬆️
Py-3.8.10 94.36% <96.88%> (+<0.01%) ⬆️
Py-3.8.18 96.69% <98.50%> (+<0.01%) ⬆️
Py-3.9.13 94.37% <96.88%> (+<0.01%) ⬆️
Py-3.9.18 96.75% <98.50%> (+0.01%) ⬆️
Py-pypy7.3.13 96.28% <98.50%> (+<0.01%) ⬆️
VM-macos 96.80% <98.50%> (+0.20%) ⬆️
VM-ubuntu 96.98% <98.50%> (+<0.01%) ⬆️
VM-windows 94.48% <96.88%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco
Copy link
Member Author

bdraco commented Jan 5, 2024

Will push this to production shortly to make sure I got all the conflicts done correctly again

@bdraco
Copy link
Member Author

bdraco commented Jan 5, 2024

Everything looks good after running for an hour. Is effectively the same code I've been running for weeks now though, just did the merge conflict again

@bdraco bdraco marked this pull request as ready for review January 5, 2024 02:53
@bdraco bdraco merged commit 1700e9d into 3.10 Jan 5, 2024
28 of 31 checks passed
@bdraco bdraco deleted the patchback/backports/3.10/c4ec3f130af3a53040b883aa2fab06fd215f9088/pr-7954 branch January 5, 2024 02:53
@bdraco bdraco mentioned this pull request Jul 22, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant