Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #8445 backport][3.10] Fixes read_timeout on WS connection not respecting ws_connect's timeouts #8444 #8447

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

arcivanov
Copy link
Contributor

Please see #8445 for the source PR

… not respecting ws_connect's timeouts aio-libs#8444

Please see aio-libs#8445 for the source PR
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jun 8, 2024
Copy link

codecov bot commented Jun 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.41%. Comparing base (266559c) to head (05ba2a2).

Additional details and impacted files
@@            Coverage Diff             @@
##             3.10    #8447      +/-   ##
==========================================
- Coverage   97.47%   97.41%   -0.07%     
==========================================
  Files         108      108              
  Lines       33406    33476      +70     
  Branches     4005     4012       +7     
==========================================
+ Hits        32563    32611      +48     
- Misses        617      635      +18     
- Partials      226      230       +4     
Flag Coverage Δ
CI-GHA 97.33% <100.00%> (-0.06%) ⬇️
OS-Linux 97.00% <100.00%> (-0.06%) ⬇️
OS-Windows 94.71% <100.00%> (+0.01%) ⬆️
OS-macOS 96.73% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 96.84% <100.00%> (+0.01%) ⬆️
Py-3.10.14 96.80% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.03% <100.00%> (+<0.01%) ⬆️
Py-3.12.4 97.14% <100.00%> (+0.01%) ⬆️
Py-3.8.10 94.44% <100.00%> (+0.01%) ⬆️
Py-3.8.18 96.69% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 96.83% <100.00%> (+<0.01%) ⬆️
Py-3.9.19 96.81% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 ?
VM-macos 96.73% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.00% <100.00%> (-0.06%) ⬇️
VM-windows 94.71% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco enabled auto-merge (squash) July 17, 2024 15:53
@bdraco bdraco merged commit 776ebc6 into aio-libs:3.10 Jul 17, 2024
31 of 32 checks passed
@bdraco
Copy link
Member

bdraco commented Jul 22, 2024

3.10.0 beta is available #8529

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants