Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Request.wait_for_disconnection() method (#4200) #8504

Conversation

Dreamsorcerer
Copy link
Member

as means of allowing request handlers to be notified of premature client disconnections.

Co-Authored-By: Andrew Svetlov andrew.svetlov@gmail.com
(cherry picked from commit 7f77733)

as means of allowing request handlers to be notified of premature client
disconnections.

Co-Authored-By: Andrew Svetlov <andrew.svetlov@gmail.com>
(cherry picked from commit 7f77733)
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jul 14, 2024
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 10 lines in your changes missing coverage. Please review.

Project coverage is 97.39%. Comparing base (3bc89fe) to head (a3b9065).
Report is 1 commits behind head on 3.10.

Files Patch % Lines
aiohttp/web_request.py 23.07% 8 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             3.10    #8504      +/-   ##
==========================================
- Coverage   97.49%   97.39%   -0.10%     
==========================================
  Files         108      108              
  Lines       33374    33388      +14     
  Branches     4004     4006       +2     
==========================================
- Hits        32537    32519      -18     
- Misses        611      637      +26     
- Partials      226      232       +6     
Flag Coverage Δ
CI-GHA 97.31% <28.57%> (-0.09%) ⬇️
OS-Linux 96.98% <28.57%> (-0.09%) ⬇️
OS-Windows 94.68% <28.57%> (-0.03%) ⬇️
OS-macOS 96.71% <28.57%> (-0.03%) ⬇️
Py-3.10.11 96.82% <28.57%> (-0.03%) ⬇️
Py-3.10.14 96.78% <28.57%> (-0.03%) ⬇️
Py-3.11.9 97.01% <28.57%> (-0.04%) ⬇️
Py-3.12.4 97.12% <28.57%> (-0.03%) ⬇️
Py-3.8.10 94.42% <28.57%> (-0.03%) ⬇️
Py-3.8.18 96.67% <28.57%> (-0.03%) ⬇️
Py-3.9.13 96.81% <28.57%> (-0.03%) ⬇️
Py-3.9.19 96.78% <28.57%> (-0.03%) ⬇️
Py-pypy7.3.16 ?
VM-macos 96.71% <28.57%> (-0.03%) ⬇️
VM-ubuntu 96.98% <28.57%> (-0.09%) ⬇️
VM-windows 94.68% <28.57%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco enabled auto-merge (squash) July 17, 2024 13:55
@bdraco bdraco merged commit 1caebc9 into 3.10 Jul 17, 2024
29 of 31 checks passed
@bdraco bdraco deleted the patchback/backports/3.10/7f777333a4ec0043ddf2e8d67146a626089773d9/pr-4200 branch July 17, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants