Restore AsyncResolver to be the default resolver #8522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdraco
added
the
backport-3.10
psf-chronographer
bot
added
the
bot:chronographer:provided
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8522 +/- ##
=======================================
Coverage 97.64% 97.64%
=======================================
Files 107 107
Lines 33313 33317 +4
Branches 3914 3916 +2
=======================================
+ Hits 32527 32531 +4
Misses 568 568
Partials 218 218
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Dreamsorcerer
approved these changes
Jul 21, 2024
bdraco
commented
Jul 21, 2024
Backport to 3.10: 💚 backport PR created✅ Backport PR branch: Backported as #8523 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jul 21, 2024
(cherry picked from commit 5a9e500)
bdraco
added a commit
that referenced
this pull request
Jul 21, 2024
…fault resolver (#8523) Co-authored-by: J. Nick Koston <nick@koston.org>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Restore
AsyncResolverto be the default resolverNote that we do not install aiodns on windows because it uses protractor event loop by default, and the
DefaultResolverwill end up beingThreadedResolveron windows.Are there changes in behavior for the user?
Reduction in executor jobs and thread switching. This can result in a significant performance boost.
Is it a substantial burden for the maintainers to support this?
no
Related issue number
The
AsyncResolverwas disabled in 9fbb7d7 because of problems with IPv6 (see #559). This is no longer an issue as theAsyncResolveruses the same underlyinggetaddrinfocall to matchThreadedResolver. Home Assistant has been usingAsyncResolverfor months now, and nobody noticed the change over.