Release 3.10.0 (attempt 2) #8552
Conversation
psf-chronographer
bot
added
the
bot:chronographer:provided
bdraco
added
the
bot:chronographer:skip
This reverts commit de871b3.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.10 #8552 +/- ##
=======================================
Coverage 97.57% 97.57%
=======================================
Files 108 108
Lines 33634 33634
Branches 4034 4034
=======================================
Hits 32819 32819
Misses 594 594
Partials 221 221
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Looks good now. Let's give this another shot. |
| it is also a good idea to ensure that any :func:`asyncio.shield` calls are replaced with | ||
| :func:`aiojobs.aiohttp.shield`. | ||
|
|
||
| Please read the updated documentation on these points: \ |
There was a problem hiding this comment.
@bdraco here's the preview: https://aiohttp--8552.org.readthedocs.build/en/8552/changes.html#removals-and-backward-incompatible-breaking-changes. This didn't change the render. The right fix would be to have a list with leading dashes or asterisks.
There was a problem hiding this comment.
I'm missing something as the render looks fine to me
Maybe its my screen size?
There was a problem hiding this comment.
Yes, it's your screen. Inspect with DevTools and you'll see that it's a paragraph with no line breaks.
FWIW, \ in RST has a rather weird meaning. Sometimes, I use it to escape invisible spaces in between bits of syntax.
P.S. I'd rather have this generate <li>s.
There was a problem hiding this comment.
(that's at 200% zoom in Firefox)
There was a problem hiding this comment.
I did try leading dashes but that didn't work either as its a list inside of a list
There was a problem hiding this comment.
It would work, but might need an extra empty line after :. Feel free to ask me for RST advice next time — I have some experience with it and Sphinx internals+extensions.
There was a problem hiding this comment.
Here's an example of a nested list that does work and is still a part of said changelog document: https://github.com/aio-libs/aiohttp/pull/8066/files#diff-bd97a3018f85ae60eb7b42978db8f4ae548d3090cc95bc3e8d64f1d825d4c5ee
| @@ -314,7 +304,7 @@ Miscellaneous internal changes | |||
|
|
|||
|
|
|||
|
|
|||
| - Restore :py:class:`~aiohttp.resolver.AsyncResolver` to be the default resolver. -- by :user:`bdraco`. | |||
| - Restored :py:class:`~aiohttp.resolver.AsyncResolver` to be the default resolver. -- by :user:`bdraco`. | |||
There was a problem hiding this comment.
That period in the middle could've been avoided.
There was a problem hiding this comment.
Do you think it’s worth adjusting before 3.10.1, or should we leave it as is?
There was a problem hiding this comment.
That's up to you. I know that it takes a lot of energy to make the change log nice. There's more things that could be fixed, like unlinked/unhighlited function mentions and perhaps other inconsistencies. I'd fix all of them if we were to work on improving it more systemically.
release tracking issue #8529
New release PR to address the feedback in #8550