Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AppKey in aiohttp 3.9 #460

Merged
merged 2 commits into from
Nov 18, 2023
Merged

Use AppKey in aiohttp 3.9 #460

merged 2 commits into from
Nov 18, 2023

Conversation

JCHacking
Copy link
Contributor

I upgrade aiohttp to version 3.9, which requires changing the AppKey usage.

@JCHacking
Copy link
Contributor Author

I see you have installed aiohttp 3.8.1 instead of 3.9.0b1
I modified it in setup.cfg > line 53
Maybe it needs to be changed somewhere else?

@Dreamsorcerer
Copy link
Member

Setup seems a little odd on this repo, there's no pinned version in the requirements file. Should sort itself out when 3.9 is a stable release, so this is probably fine.

@JCHacking
Copy link
Contributor Author

JCHacking commented Nov 11, 2023

I see you have installed aiohttp 3.8.1 instead of 3.9.0b1 I modified it in setup.cfg > line 53 Maybe it needs to be changed somewhere else?

I see that this version is installed because in requirements/ci.txt is pytest-aiohttp==1.0.5 which must have the aiohttp 3.8.1 dependency version.

I understand that pytest-aiohttp is not up to date, so once the new version is released you will have to update that line to make it work.

@Dreamsorcerer
Copy link
Member

I see that this version is installed because in requirements/ci.txt is pytest-aiohttp==1.0.5 which must have the aiohttp 3.8.1 dependency version.

That's a minimum bound, it installed the latest stable version: https://github.com/aio-libs/aiojobs/actions/runs/6836361766/job/18591186408?pr=460#step:4:111

@JCHacking
Copy link
Contributor Author

And putting in requirements.txt >=3.9.0b1 would be ok? Or would this make that in the future if there is any beta I choose it instead of just using stable versions?

@Dreamsorcerer
Copy link
Member

I'll just retry the CI once 3.9 is released, it should pass then. Mainly I just want to have the PRs lined up, so I can release them all in a day or weekend. Normally, we'd have all dependencies pinned in the requirements file (https://github.com/aio-libs/aiohttp-jinja2/blob/master/requirements.txt), but that's a task for a different PR.

@Dreamsorcerer Dreamsorcerer merged commit 58e16fa into aio-libs:master Nov 18, 2023
12 checks passed
@JCHacking JCHacking deleted the update_aiohttp_3.9 branch November 18, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants