added .begin_nested() cm support #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Explicit tests for |
Current coverage is 92.77% (diff: 100%)@@ master #208 diff @@
==========================================
Files 12 12
Lines 1312 1315 +3
Methods 0 0
Messages 0 0
Branches 161 161
==========================================
+ Hits 1217 1220 +3
Misses 69 69
Partials 26 26
|
|
@asvetlov I added one test case. Not sure if it fit's your needs. |
|
Cool! Thanks! |
|
Thanks, please don't forget to close #201, I did not mentionedin the commit ;( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added support for .begin_nested() cm
In test suite teher are generally no context manager tests for
.begin()so I did not create any for.begin_nested().Existing tests passed.