Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #189 hstore when using ReadDictCursor #512

Merged
merged 2 commits into from
Nov 3, 2018

Conversation

angaz
Copy link
Contributor

@angaz angaz commented Oct 24, 2018

I saw the PR that hadn't been completed, so I made my own to get the fix merged. I hope it's what you are looking for.

I didn't know where to put the test. I hope I chose a good place.

@codecov
Copy link

codecov bot commented Oct 24, 2018

Codecov Report

Merging #512 into master will increase coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #512     +/-   ##
=========================================
+ Coverage   93.66%   93.76%   +0.1%     
=========================================
  Files          25       25             
  Lines        3744     3756     +12     
  Branches      199      199             
=========================================
+ Hits         3507     3522     +15     
+ Misses        199      196      -3     
  Partials       38       38
Impacted Files Coverage Δ
tests/test_connection.py 98.27% <100%> (+0.04%) ⬆️
tests/test_sa_types.py 90.42% <0%> (+3.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 514f878...23c66fc. Read the comment docs.

@vir-mir vir-mir merged commit 57b5d55 into aio-libs:master Nov 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants