Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Towncrier philosophy link #911

Merged
merged 1 commit into from
Jan 7, 2024

Conversation

Jamim
Copy link
Contributor

@Jamim Jamim commented Jan 6, 2024

Hello @webknjaz,
There's one more broken link to fix.

What do these changes do?

These changes fix a broken link to towncrier's philosophy.

Are there changes in behavior for the user?

Link from Contributing docs to towncrier's philosophy will be fixed.

Related issue number

Similar PR:

Checklist

  • I think the code is well written
  • Documentation reflects the changes

Best regards!

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jan 6, 2024
@Jamim Jamim force-pushed the fix/towncrier-philosophy-link branch from 64a9448 to ab32035 Compare January 6, 2024 21:47
Copy link

codecov bot commented Jan 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d54828d) 76.58% compared to head (ab32035) 76.58%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #911   +/-   ##
=======================================
  Coverage   76.58%   76.58%           
=======================================
  Files           5        5           
  Lines         504      504           
=======================================
  Hits          386      386           
  Misses        118      118           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@webknjaz webknjaz merged commit 4ce6b66 into aio-libs:master Jan 7, 2024
44 checks passed
@Jamim Jamim deleted the fix/towncrier-philosophy-link branch January 7, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants