fix(source-microsoft-sharepoint): handle wrong folder name #45646
+46
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[skip ci] Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
octavia-squidington-iii
added
the
area/documentation
artem1205
force-pushed
the
artem1205/source-sharepoint-OC
branch
from
949aa53
to
1536657
Compare
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
|
/approve-regression-tests
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Resolving https://github.com/airbytehq/oncall/issues/6481
Sharepoint can have an access to different/many
drives. We get an exception trying to get the folder by name from the wrong drive, that's why we have to handle this type of exception and continue search in another drive.How
handle wrong folder name
Review guide
airbyte-integrations/connectors/source-microsoft-sharepoint/source_microsoft_sharepoint/utils.pyairbyte-integrations/connectors/source-microsoft-sharepoint/source_microsoft_sharepoint/stream_reader.pyUser Impact
Can this PR be safely reverted and rolled back?