destination-dev-null: merge cloud and OSS #45651
Open
+211
−337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
2 tasks
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @stephane-airbyte and the rest of your teammates on |
This was referenced Sep 18, 2024
stephane-airbyte
force-pushed
the
stephane/09-18-destination-e2e_merge_cloud_and_oss
branch
from
22217be
to
3d27a3b
Compare
stephane-airbyte
force-pushed
the
stephane/09-18-destination-e2e_upgrade_cdk
branch
from
95cc53d
to
5bf6469
Compare
stephane-airbyte
force-pushed
the
stephane/09-18-destination-e2e_merge_cloud_and_oss
branch
from
3d27a3b
to
4d46537
Compare
stephane-airbyte
force-pushed
the
stephane/09-18-destination-e2e_upgrade_cdk
branch
from
5bf6469
to
25bde21
Compare
stephane-airbyte
force-pushed
the
stephane/09-18-destination-e2e_merge_cloud_and_oss
branch
from
4d46537
to
236bd09
Compare
| @@ -2,7 +2,7 @@ data: | |||
| connectorSubtype: unknown | |||
| connectorType: destination | |||
| definitionId: 2eb65e87-983a-4fd7-b3e3-9d9dc6eb8537 | |||
There was a problem hiding this comment.
Just to clarify, if we drop the cloud version but don't change the definitionId or name of the oss version, then we effectively create a new cloud connector with a new name? That is what we want? All existing connections using dev-null will just be parked at the old version until they switch over?
stephane-airbyte
force-pushed
the
stephane/09-18-destination-e2e_upgrade_cdk
branch
from
25bde21
to
0844477
Compare
stephane-airbyte
force-pushed
the
stephane/09-18-destination-e2e_merge_cloud_and_oss
branch
from
236bd09
to
99cab00
Compare
stephane-airbyte
force-pushed
the
stephane/09-18-destination-e2e_merge_cloud_and_oss
branch
from
99cab00
to
4f03511
Compare
stephane-airbyte
force-pushed
the
stephane/09-18-destination-e2e_upgrade_cdk
branch
from
0844477
to
ba0b812
Compare
stephane-airbyte
force-pushed
the
stephane/09-18-destination-e2e_merge_cloud_and_oss
branch
from
4f03511
to
b43ab0e
Compare
stephane-airbyte
force-pushed
the
stephane/09-18-destination-e2e_upgrade_cdk
branch
from
ba0b812
to
11a40c5
Compare
stephane-airbyte
force-pushed
the
stephane/09-18-destination-e2e_merge_cloud_and_oss
branch
from
b43ab0e
to
2148679
Compare
stephane-airbyte
force-pushed
the
stephane/09-18-destination-e2e_merge_cloud_and_oss
branch
from
afa13f1
to
8843925
Compare
stephane-airbyte
force-pushed
the
stephane/09-18-destination-e2e_upgrade_cdk
branch
from
0af4c79
to
5e96375
Compare
stephane-airbyte
force-pushed
the
stephane/09-18-destination-e2e_merge_cloud_and_oss
branch
from
8843925
to
9d66c12
Compare
stephane-airbyte
force-pushed
the
stephane/09-18-destination-e2e_upgrade_cdk
branch
from
5e96375
to
2946cca
Compare
stephane-airbyte
force-pushed
the
stephane/09-18-destination-e2e_merge_cloud_and_oss
branch
from
9d66c12
to
a657ecb
Compare
stephane-airbyte
changed the title
stephane-airbyte
force-pushed
the
stephane/09-18-destination-e2e_merge_cloud_and_oss
branch
from
a657ecb
to
00b415b
Compare
stephane-airbyte
force-pushed
the
stephane/09-18-destination-e2e_upgrade_cdk
branch
from
2946cca
to
8a624a3
Compare
stephane-airbyte
force-pushed
the
stephane/09-18-destination-e2e_merge_cloud_and_oss
branch
from
00b415b
to
77d7133
Compare
| @@ -42,6 +48,33 @@ constructor( | |||
| ] | |||
| } | |||
|
|
|||
| override fun spec(): ConnectorSpecification { | |||
There was a problem hiding this comment.
Is this backwards? You remove everything but silent from the !isCloudDeployment version
| /** 1. Update the title. 2. Only keep the "silent" mode. */ | ||
| val spec = super.spec() | ||
|
|
||
| (spec.connectionSpecification as ObjectNode).put("title", DEV_NULL_DESTINATION_TITLE) |
There was a problem hiding this comment.
This is the cloud title also?
There was a problem hiding this comment.
I guess I fucked that one up? I reverted them. I'll fix
There was a problem hiding this comment.
actually, why should we use different names, now that they're the same connector?
There was a problem hiding this comment.
🤷 Minimal disruption? Keeping parity with what exists?
stephane-airbyte
force-pushed
the
stephane/09-18-destination-e2e_merge_cloud_and_oss
branch
2 times, most recently
from
6d53ad2
to
77508cb
Compare
stephane-airbyte
force-pushed
the
stephane/09-18-destination-e2e_merge_cloud_and_oss
branch
from
77508cb
to
b665715
Compare
stephane-airbyte
force-pushed
the
stephane/09-18-destination-e2e_merge_cloud_and_oss
branch
from
b665715
to
0945d13
Compare
johnny-schmidt
approved these changes
Sep 19, 2024
stephane-airbyte
force-pushed
the
stephane/09-18-destination-e2e_merge_cloud_and_oss
branch
from
0945d13
to
7b34c61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
How
Review guide
User Impact
Can this PR be safely reverted and rolled back?