Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature : non-blocking beautify #4623

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

salmanul
Copy link

Issue #, if available:

Description of changes: Enhance beautify method using requestAnimationFrame for handling large textual contents, Current enhancement will reduce the blocking of main thread while beautifying in the editor.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@andrewnester
Copy link
Contributor

We recently introduced new way of configuring beautify formatting options, so it can be better to move it there
#4697

Also please resolve the conflicts

@salmanul
Copy link
Author

K, it can be moved over there.
I will update the PR once it is resolved.

@salmanul salmanul force-pushed the feature/non-blocking-beautify-ext branch from fbe1219 to b61765f Compare May 13, 2022 04:19
@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #4623 (ecb35a8) into master (33cf1c6) will decrease coverage by 0.00%.
The diff coverage is 43.75%.

@@            Coverage Diff             @@
##           master    #4623      +/-   ##
==========================================
- Coverage   71.19%   71.18%   -0.01%     
==========================================
  Files         553      553              
  Lines       55598    55611      +13     
  Branches    10392    10394       +2     
==========================================
+ Hits        39584    39588       +4     
- Misses      16014    16023       +9     
Flag Coverage Δ
unittests 71.18% <43.75%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/ace/ext/beautify.js 93.05% <43.75%> (-3.30%) ⬇️
lib/ace/range.js 84.82% <0.00%> (-0.69%) ⬇️
lib/ace/editor.js 79.71% <0.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33cf1c6...ecb35a8. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants