New body isArchived for PATCH /api/v1/rituals/default
#141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
6 tasks
mlajkim
added a commit
to ajktown/ConsistencyGPT
that referenced
this pull request
Aug 11, 2024
…groups appeared (#56) # Background When you move your action group up or down, archived action groups also appeared. This is due to that API did not support `isArchived` beforehand. The API is now supported with the following PR: ajktown/api#141 ## Checklist Before PR Review - [x] The following has been handled: - `Draft` is set for this PR - `Title` is checked - `Background` is filled - `Assignee` is set - `Labels` are set - `development` is linked if related issue exists ## Checklist (Right Before PR Review Request) - [x] The following has been handled: - `TODOs` are handled and checked - Final Operation Check is done - Make this PR as an open PR ## Checklist (Reviewers) - [x] Check if there are any other missing TODOs that are not yet listed - [x] Review Code - [x] Every item on the checklist has been addressed accordingly - [x] If `development` is associated to this PR, you must check if every TODOs are handled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Endpoint
GET /api/v1/rituals/already support a keyisArchivedin a body.The
PATCH /api/v1/rituals/defaultshould do the sameChecklist Before PR Review
Draftis set for this PRTitleis checkedBackgroundis filledAssigneeis setLabelsare setdevelopmentis linked if related issue existsChecklist (Right Before PR Review Request)
TODOsare handled and checkedChecklist (Reviewers)
developmentis associated to this PR, you must check if every TODOs are handled