Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Query GetActionGroupByIdQueryDTO for /api/v1/action-groups/{id} #143

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mlajkim
Copy link
Contributor

@mlajkim mlajkim commented Aug 30, 2024

Background

ajktown/ConsistencyGPT#8

I want the action groups to have selectable year at this point, before the end of this year.
API first must accept a query year for /api/v1/action-groups/{id}.

|   year    |                Meaning                |
|:---------:|:-------------------------------------:|
| undefined |      Returns the latest 365 days      |
|   2024    | Returns the latest 365 days from 2024 |

Checklist Before PR Review

  • The following has been handled:
    • Draft is set for this PR
    • Title is checked
    • Background is filled
    • Assignee is set
    • Labels are set
    • development is linked if related issue exists

Checklist (Right Before PR Review Request)

  • The following has been handled:
    • TODOs are handled and checked
    • Final Operation Check is done
    • Make this PR as an open PR

Checklist (Reviewers)

  • Check if there are any other missing TODOs that are not yet listed
  • Review Code
  • Every item on the checklist has been addressed accordingly
  • If development is associated to this PR, you must check if every TODOs are handled

@mlajkim mlajkim self-assigned this Aug 30, 2024
@mlajkim mlajkim added the enhancement New feature or request label Aug 30, 2024
@mlajkim mlajkim marked this pull request as draft August 30, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant