Skip to content

Commit

Permalink
no brackets around env variables
Browse files Browse the repository at this point in the history
  • Loading branch information
MaxHorstmann committed Jul 6, 2023
1 parent 864f825 commit 216bd74
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion config/prow/k8s/app/crier.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ spec:
- --github-endpoint=https://api.github.com
- --github-workers=10
- --kubernetes-blob-storage-workers=10
- --github-app-id=$(GITHUB_APP_ID)
- --github-app-id=$GITHUB_APP_ID
- --github-app-private-key-path=/etc/github/cert
env:
- name: GITHUB_APP_ID
Expand Down
2 changes: 1 addition & 1 deletion config/prow/k8s/app/deck.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ spec:
- --github-graphql-endpoint=http://ghproxy/graphql
- --s3-credentials-file=/etc/s3-credentials/service-account.json
- --spyglass=true
- --github-app-id=$(GITHUB_APP_ID)
- --github-app-id=$GITHUB_APP_ID
- --github-app-private-key-path=/etc/github/cert
env:
- name: GITHUB_APP_ID
Expand Down
2 changes: 1 addition & 1 deletion config/prow/k8s/app/hook.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ spec:
- --config-path=/etc/config/config.yaml
- --github-endpoint=http://ghproxy
- --github-endpoint=https://api.github.com
- --github-app-id=$(GITHUB_APP_ID)
- --github-app-id=$GITHUB_APP_ID
- --github-app-private-key-path=/etc/github/cert
env:
- name: GITHUB_APP_ID
Expand Down
2 changes: 1 addition & 1 deletion config/prow/k8s/app/prow-controller-manager.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ spec:
- --github-endpoint=http://ghproxy
- --github-endpoint=https://api.github.com
- --enable-controller=plank
- --github-app-id=$(GITHUB_APP_ID)
- --github-app-id=$GITHUB_APP_ID
- --github-app-private-key-path=/etc/github/cert
env:
- name: GITHUB_APP_ID
Expand Down
2 changes: 1 addition & 1 deletion config/prow/k8s/app/secrets-gcs-service-account.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v1
data:
# referenced by a lots of official k8s jobs, this is a fake secret to bypass the mount phase
service-account.json: $(FAKE_MOUNT_SECRET)
service-account.json: $FAKE_MOUNT_SECRET
kind: Secret
metadata:
name: service-account
Expand Down
2 changes: 1 addition & 1 deletion config/prow/k8s/app/statusreconciler.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ spec:
- --github-endpoint=https://api.github.com
- --s3-credentials-file=/etc/s3-credentials/service-account.json
- --status-path=s3://status-reconciler/status-reconciler-status
- --github-app-id=$(GITHUB_APP_ID)
- --github-app-id=$GITHUB_APP_ID
- --github-app-private-key-path=/etc/github/cert
env:
- name: GITHUB_APP_ID
Expand Down
2 changes: 1 addition & 1 deletion config/prow/k8s/app/tide.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ spec:
- --s3-credentials-file=/etc/s3-credentials/service-account.json
- --status-path=s3://tide/tide-status
- --history-uri=s3://tide/tide-history.json
- --github-app-id=$(GITHUB_APP_ID)
- --github-app-id=$GITHUB_APP_ID
- --github-app-private-key-path=/etc/github/cert
env:
- name: GITHUB_APP_ID
Expand Down

0 comments on commit 216bd74

Please sign in to comment.