Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use codecov-action v4 #487

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Conversation

skirpichev
Copy link
Contributor

It seems, https://app.codecov.io/gh/aleaxit/gmpy - not updating. And coverage for new pull requests is missing too:
https://app.codecov.io/gh/aleaxit/gmpy/pulls?prStates%5B0%5D=OPEN

This update codecov-action version and add fail_ci_if_error option to prevent CI failures on the master. In this form, submitting data works in mpmath's prs.

If someone menages to add CODECOV_TOKEN (as it's explained in https://github.com/codecov/codecov-action/?tab=readme-ov-file#usage)

  • then we could remove fail_ci_if_error option (defaults to true).

It seems, https://app.codecov.io/gh/aleaxit/gmpy - not updating.
And coverage for new pull requests too:
https://app.codecov.io/gh/aleaxit/gmpy/pulls?prStates%5B0%5D=OPEN

This update codecov-action version and add fail_ci_if_error to
prevent CI failures on the master.  In this form, submitting data
works in mpmath's prs.

If someone menages to add CODECOV_TOKEN (as it's explained in
https://github.com/codecov/codecov-action/?tab=readme-ov-file#usage)
- then we could remove fail_ci_if_error option (defaults to true).
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.50%. Comparing base (224745b) to head (374b37f).
Report is 24 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #487      +/-   ##
==========================================
- Coverage   85.52%   85.50%   -0.03%     
==========================================
  Files          50       50              
  Lines       11656    11645      -11     
  Branches     2202     2201       -1     
==========================================
- Hits         9969     9957      -12     
- Misses       1687     1688       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@casevh casevh merged commit 3215253 into aleaxit:master Jun 28, 2024
11 checks passed
@casevh
Copy link
Collaborator

casevh commented Jun 28, 2024

Thanks.

@skirpichev skirpichev deleted the use-codecov-action-v4 branch June 28, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants