Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cert manager version #15

Merged
merged 14 commits into from
Feb 9, 2023
Merged

Fix cert manager version #15

merged 14 commits into from
Feb 9, 2023

Conversation

RafalKorepta
Copy link
Contributor

@RafalKorepta RafalKorepta commented Feb 8, 2023 •
edited
Loading

This PR includes:

  • fix for validation of cert manager container tag
  • fix reporting certificate check error
  • improve the e2e test
    • change v1.10.0-alpha to v1.10.0
    • adds v1.11.0 cert manager test
  • update kuttl version
  • fix e2e test script to work on mac
  • add 1.3.3 e2e test
  • move 1.6.3 test out of 1.7.3 folder
  • removes too old tests which can not work if there is no v1beta1 admissionregistration.k8s.io
    • 1.0.0 version
    • 1.1.1 version
    • 1.2.0 version

Rafal Korepta added 14 commits February 8, 2023 13:52
Validate only v1. prefix from cert manager container tag
34f4a9b 
Starting from v1.7.0 the v1alpha2 version of the custom resource definitions
was removed from cert manager project.
Return correct certificate error
2af9b67 
Due to this bug any e2e test was silently pass starting from v1.7 version of
the cert manager.
Change e2e 1.10.0-alpha test to official 1.10.0 release
ee03588
Add v1.11.0 e2e test
09d0e7e
Update kuttl version to the latest v0.15.0
25cab8a
Fix the e2e test script check for Darwin
3093130
Remove 1.0.0 e2e tests
85fe7c6
Remove 1.1.1 e2e test
319ab85 
In 1.25 kubernetes version cert-manager ca injector does not work due to
the following error:

```
E0208 17:20:00.381911       1 start.go:119] cert-manager/ca-injector "msg"="manager goroutine exited" "error"=null
I0208 17:20:01.529717       1 request.go:645] Throttling request took 1.048204385s, request: GET:https://10.96.0.1:443/apis/cert-manager.io/v1?timeout=32s
E0208 17:20:02.081686       1 start.go:151] cert-manager/ca-injector "msg"="Error registering certificate based controllers. Retrying after 5 seconds." "error"="no matches for kind \"MutatingWebhookConfiguration\" in version \"admissionregistration.k8s.io/v1beta1\""
Error: error registering secret controller: no matches for kind "MutatingWebhookConfiguration" in version "admissionregistration.k8s.io/v1beta1"
```
Remove 1.2.0 e2e test
f6cd5c7 
In 1.25 kubernetes version cert-manager ca injector does not work due to
the following error:

```
E0208 17:20:00.381911       1 start.go:119] cert-manager/ca-injector "msg"="manager goroutine exited" "error"=null
I0208 17:20:01.529717       1 request.go:645] Throttling request took 1.048204385s, request: GET:https://10.96.0.1:443/apis/cert-manager.io/v1?timeout=32s
E0208 17:20:02.081686       1 start.go:151] cert-manager/ca-injector "msg"="Error registering certificate based controllers. Retrying after 5 seconds." "error"="no matches for kind \"MutatingWebhookConfiguration\" in version \"admissionregistration.k8s.io/v1beta1\""
Error: error registering secret controller: no matches for kind "MutatingWebhookConfiguration" in version "admissionregistration.k8s.io/v1beta1"
```
Remove wrong folder structure
72439f1
Add 1.3.3 e2e test
364069b
Add 1.6.3 e2e test
e85828b
Add --debug falg to the tests
2c046e3
Sync cert manager deployments
9c4f21a
@alenkacz alenkacz merged commit e625e50 into alenkacz:main Feb 9, 2023
@alenkacz
Copy link
Owner

alenkacz commented Feb 9, 2023

Thank you!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RafalKorepta @alenkacz