-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Examples with custom tiles #207
Conversation
8c31d2c
to
261d75b
Compare
tried react-snapshot, but it has this issue geelen/react-snapshot#16 |
Added Marker, Popup example |
@stereobooster Thanks for the PR, Great job but I am not sure about the value of having examples with custom tiles. In the end what changed for the library is just the style passed down to the map, it doesn't show more features that What I can propose you is to keep this into a different repository and I will add a link to it in the readme as "More examples using react-mapbox-gl", what do you think about it ? |
My intention was to show that library actually not coupled with Mapbox tile server on one side, on other side this is not well documented feature. I like how examples organised in styleguidist or in https://uber.github.io/react-map-gl/#/: Code example + Demo. From my POV the more examples the better. WDYT? |
I agree with you for the organisation of the examples (code + example), let me have a look at the actual result of the examples on your PR (will check this week). |
Just a note this is not deployable without some kind of static prerenderer, like react-snapshot, because I use react-router. |
29241da
to
7b19331
Compare
Sorry I will close this PR as the examples changed completely with the version 2.0.0 |
Examples with custom tiles. Probably need to clean up it a bit. What do you think?