Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding User-Agent and updating model definitions #8

Merged
merged 1 commit into from
Dec 20, 2019
Merged

Adding User-Agent and updating model definitions #8

merged 1 commit into from
Dec 20, 2019

Conversation

Shreyas-vgr
Copy link
Contributor

Description

  • Adding User-Agent values on SmapiServiceClients.
  • Updated model definitions.
  • Updated ask-sdk-model-runtime test cases to use UnitTest framework

Testing

  • nosetests tests success no ask-sdk-model-runtime package.

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • The change is generic and can be done across all model classes.
  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Adding User-Agent and updating model definitions
74ea73b 
Updated ask-sdk-model-runtime test cases to use UnitTest framework
@Shreyas-vgr Shreyas-vgr requested review from nikhilym and a team December 19, 2019 03:50
nikhilym
nikhilym approved these changes Dec 20, 2019
View reviewed changes
Copy link
Contributor

@nikhilym nikhilym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🚢

@Shreyas-vgr Shreyas-vgr requested a review from a team December 20, 2019 18:20
@Shreyas-vgr Shreyas-vgr merged commit e0f3ae9 into alexa:master Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhilym nikhilym nikhilym approved these changes

@ShenChen93 ShenChen93 ShenChen93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Shreyas-vgr @nikhilym @ShenChen93