Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix writeDouble and writeFloat of JSONWriter when value Not a Number … #1565

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

yanxutao89
Copy link
Collaborator

…, for issue #1562

What this PR does / why we need it?

fix writeDouble and writeFloat of JSONWriter when value Not a Number , for issue #1562

Summary of your change

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 40.00% and project coverage change: +0.01 🎉

Comparison is base (83746b3) 75.97% compared to head (37756ea) 75.98%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1565      +/-   ##
============================================
+ Coverage     75.97%   75.98%   +0.01%     
- Complexity    20535    20572      +37     
============================================
  Files           629      631       +2     
  Lines         80941    81108     +167     
  Branches      17697    17704       +7     
============================================
+ Hits          61493    61633     +140     
- Misses        12149    12230      +81     
+ Partials       7299     7245      -54     
Impacted Files Coverage Δ
...rc/main/java/com/alibaba/fastjson2/JSONWriter.java 77.38% <40.00%> (+0.40%) ⬆️

... and 78 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wenshao wenshao merged commit 8876c08 into alibaba:main Jun 14, 2023
@yanxutao89 yanxutao89 deleted the fix-1562 branch August 30, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants