Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The abnormal exit mechanism does not take effect #11926

Closed
five111 opened this issue Apr 7, 2024 · 1 comment · Fixed by #12045
Closed

The abnormal exit mechanism does not take effect #11926

five111 opened this issue Apr 7, 2024 · 1 comment · Fixed by #12045
Labels
area/Config kind/enhancement Category issues or prs related to enhancement.

Comments

@five111
Copy link

five111 commented Apr 7, 2024

os:eulerosv2r12
jdk:1.8
nacos:2.1.0
We are doing performance testing because there is a large amount of disk space in the container and errors are reported.
After checking the source code, I found an abnormal exit mechanism, but it didn't work.
At the same time, I have a question. Is it reasonable to exit the process directly?

The reason is that nacos cannot correctly determine the exception return information.
os:eulerosv2r12
jdk:1.8
nacos:2.1.0
我们在做性能测试因为容器内磁盘空间大量报错,
查阅源码发现有异常退出机制 但并未奏效。
原因是nacos的无法正确判断异常返回信息。
同时有个疑问 这里直接退出进程是否合理。

error log

config_20240402075128821.zip:2024-04-02 07:51:13.662+02:00 |ERROR|com.alibaba.nacos.server.DumpTaskManager.0||||124|com.alibaba.nacos.config.dumpLog [dump-exception] save disk error. tenant12345678901234567890123456712345678901234567890123456789012345678901234567890123456789012345_344481+group_tenant12345678901234567890123456712345678901234567890123456789012345678901234567890123456789012345_102511+2111, java.nio.file.FileSystemException: /***********/data/tenant-config-data/2111/group_tenant12345678901234567890123456712345678901234567890123456789012345678901234567890123456789012345_102511/tenant12345678901234567890123456712345678901234567890123456789012345678901234567890123456789012345_344481: No space left on device

not work code

if (NO_SPACE_CN.equals(errMsg) || NO_SPACE_EN.equals(errMsg) || errMsg.contains(DISK_QUOTA_CN)

@KomachiSion
Copy link
Collaborator

可以优化一下判断条件,把equals改为contains

但是不能一异常就退出, 要考虑到普通的IO异常

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Config kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
2 participants