Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(develop): [ISSUES #12013] startup.sh support environment CUSTOM_NACOS_MEMORY #12014

Merged
merged 5 commits into from
May 6, 2024

Conversation

caoyanan666
Copy link
Contributor

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

support #12013

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@CLAassistant
Copy link

CLAassistant commented Apr 24, 2024

CLA assistant check
All committers have signed the CLA.

@caoyanan666 caoyanan666 changed the title feat(develop): startup.sh support environment DISABLE_NACOS_DEFAULT_MEMORY_SIZE feat(develop): startup.sh support environment DISABLE_NACOS_DEFAULT_MEMORY_SETTING Apr 24, 2024
@KomachiSion
Copy link
Collaborator

Please fix your commit user and email and sign CLA

@caoyanan666 caoyanan666 force-pushed the feat-startupsh branch 2 times, most recently from 0cfb48f to 825dee1 Compare April 25, 2024 02:36
@caoyanan666 caoyanan666 changed the title feat(develop): startup.sh support environment DISABLE_NACOS_DEFAULT_MEMORY_SETTING feat(develop): startup.sh support environment CUSTOM_NACOS_MEMORY Apr 25, 2024
@caoyanan666 caoyanan666 changed the title feat(develop): startup.sh support environment CUSTOM_NACOS_MEMORY feat(develop): [ISSUES #12013] startup.sh support environment CUSTOM_NACOS_MEMORY Apr 25, 2024
@caoyanan666
Copy link
Contributor Author

@KomachiSion PTAL

Copy link
Collaborator

@KomachiSion KomachiSion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you modified the startup.cmd also?

@caoyanan666
Copy link
Contributor Author

Can you modified the startup.cmd also?

Done

@KomachiSion KomachiSion added the kind/enhancement Category issues or prs related to enhancement. label May 6, 2024
@KomachiSion KomachiSion merged commit 9980735 into alibaba:develop May 6, 2024
7 checks passed
@KomachiSion KomachiSion added this to the 2.4.0 milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants