Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug. #200

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix bug. #200

wants to merge 2 commits into from

Conversation

KeepRunning90
Copy link

@KeepRunning90 KeepRunning90 commented Apr 3, 2019

Modify the file "xdl-algorithm-solution/TDM/src/tdm/bitmap_test.cc" as follows:

--- a/xdl-algorithm-solution/TDM/src/tdm/bitmap_test.cc
+++ b/xdl-algorithm-solution/TDM/src/tdm/bitmap_test.cc
@@ -34,15 +34,15 @@ TEST(Bitmap, TestSetFilter) {
   ASSERT_TRUE(bitmap.set_filter(index, true));
   ASSERT_TRUE(bitmap.is_filtered(index));
 
-  index = 1000;
+  index = 100000;
   ASSERT_TRUE(bitmap.set_filter(index, true));
   ASSERT_TRUE(bitmap.is_filtered(index));
 
-  index = 2000;
+  index = 200000;
   ASSERT_TRUE(bitmap.set_filter(index, true));
   ASSERT_TRUE(bitmap.is_filtered(index));
 
-  index = 5000;
+  index = 500000;
   ASSERT_TRUE(bitmap.set_filter(index, true));
   ASSERT_TRUE(bitmap.is_filtered(index));
 
@@ -51,7 +51,12 @@ TEST(Bitmap, TestSetFilter) {
 
 TEST(Bitmap, TestSave) {
   Bitmap bitmap("bitmap.bm");
-  ASSERT_TRUE(bitmap.is_filtered(5000));
+  ASSERT_TRUE(bitmap.is_filtered(500000));

The running result is:
[==========] Running 3 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 3 tests from Bitmap
[ RUN ] Bitmap.TestConstructor
[ OK ] Bitmap.TestConstructor (0 ms)
[ RUN ] Bitmap.TestSetFilter
Segmentation fault (core dumped)

@CLAassistant
Copy link

CLAassistant commented Apr 3, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants