Work around non-UTF-8 output from commands #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If commands call output something other than UTF-8, then try decoding as ISO-8859-1, which should cover everything. This way, we shouldn't get any encoding errors any more.
TimoWilken
force-pushed
the
encoding-errors
branch
from
5f30c45
to
21a75c8
Compare
Codecov Report
@@ Coverage Diff @@
## master #752 +/- ##
==========================================
- Coverage 87.18% 87.17% -0.02%
==========================================
Files 29 29
Lines 2973 2970 -3
==========================================
- Hits 2592 2589 -3
Misses 381 381
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If commands call output something other than UTF-8, then try decoding as ISO-8859-1, which should cover everything. This way, we shouldn't get any encoding errors any more.
Fixes #738.