-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add command-line option to force rebuilding specific packages #756
Conversation
This is an alternative to adding `force_rebuild: true` to the alidist recipe, so that alidist doesn't have to be changed.
at least from description is what i need, but to actually install the alibuild in devel mode to check it out it will take some time .. |
Codecov Report
@@ Coverage Diff @@
## master #756 +/- ##
==========================================
+ Coverage 87.17% 87.18% +0.01%
==========================================
Files 29 29
Lines 2970 2974 +4
==========================================
+ Hits 2589 2593 +4
Misses 381 381
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
OK, thanks @adriansev! Let me know when you've had time to try it.
You're right, that does work. I've made it consistent in the latest commit, so you can use |
so, i will just leave here as a log the problems encountered and at the end i will ping you...
moreover, something is wrong with the shebang adaptation as i got this:
after modification by hand to a proper line ( |
@TimoWilken i can confirm that it works as advertised: after the initial build, another build command will tell me that |
@@ -89,14 +86,23 @@ def doParseArgs(star): | |||
help=("Fetch updates to repositories in MIRRORDIR. Required but nonexistent " | |||
"repositories are always cloned, even if this option is not given.")) | |||
|
|||
build_parser.add_argument("--no-local", dest="noDevel", metavar="PKGLIST", default="", type=csv_list, | |||
build_parser.add_argument("--no-local", dest="noDevel", metavar="PACKAGE", default=[], action="append", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean it will not support comma separated lists anymore? I do not think this is acceptable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, 2ebab24 fixes this so that --no-devel
and --force-rebuild
work like --disable
(in that --disable A,B
and --disable A --disable B
are equivalent).
@@ -89,14 +86,23 @@ def doParseArgs(star): | |||
help=("Fetch updates to repositories in MIRRORDIR. Required but nonexistent " | |||
"repositories are always cloned, even if this option is not given.")) | |||
|
|||
build_parser.add_argument("--no-local", dest="noDevel", metavar="PKGLIST", default="", type=csv_list, | |||
build_parser.add_argument("--no-local", dest="noDevel", metavar="PACKAGE", default=[], action="append", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean it will not support comma separated lists anymore? I do not think this is acceptable.
I've released v1.11.3 with this change. |
This is an alternative to adding
force_rebuild: true
to the alidist recipe, so that alidist doesn't have to be changed.Example:
(You can specify multiple packages to rebuild by giving the option multiple times. This makes it consistent with how
--disable
works.)@adriansev: could you check whether this does what you need?