Remove deprecated rel="external" styling #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like ruby linting failures, I don't know why since no ruby code has been touched. |
|
Might need a rebase. |
As part of alphagov/govuk_frontend_toolkit#293 we removed external link icon styles as there is not an obvious user need. However frontend still has spacing with these icons in mind.
NickColley
force-pushed
the
remove-rel-external-styling
branch
from
45cfd4f
to
91cc51d
Compare
|
Okay I've rebased this, let's see if it fancies going green this time. 👍 |
robinwhittleton
approved these changes
Nov 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of alphagov/govuk_frontend_toolkit#293
we removed external link icon styles as there is not an obvious
user need.
However frontend still has spacing with these icons in mind.