Replace organisation logos with metadata #3310
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is a spike to explore how easy/hard it would be to replace organisation logos on HTML attachments with a call to the metadata component instead: https://components.publishing.service.gov.uk/component-guide/metadata#on_a_dark_background_without_padding Some organisations have custom logos, but we only display the logo if it will be the only logo on the page. If it will sit alongside other logos, we hide the custom logo. This behaviour is weird and unexpected.
| %> | ||
| <p class="publication-header__last-changed"><%= @content_item.last_changed %></p> | ||
| <% end %> | ||
| <div class="govuk-!-margin-top-5"> |
There was a problem hiding this comment.
Nice, I like the approach of using a utility class from the design system here, avoids adding custom CSS / stylesheet and easy to understand what it does just from looking at the view template 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is a spike to explore how easy/hard it would be to replace organisation logos on HTML attachments with a call to the metadata component instead:
https://components.publishing.service.gov.uk/component-guide/metadata#on_a_dark_background_without_padding
Some organisations have custom logos, but we only display the logo if it will be the only logo on the page. If it will sit alongside other logos, we hide the custom logo. This behaviour is weird and unexpected.
Live site
Review app
Follow these steps if you are doing a Rails upgrade.
Trello: https://trello.com/c/3jez4Zg9/2799-understand-technical-design-and-content-implications-of-removing-org-logos-from-html-attachments