Add middleman; use Travis to test builds #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombye
approved these changes
Jun 7, 2017
There was a problem hiding this comment.
I'd argue in future it might be better to specify the ruby version in a .ruby-version file to match other ruby projects here and maybe to move the script into a test rake task to make it explicit what it's for (other than in the docs) but it's my opinion rather than solid reasoning and it's more important to get the build running before tweaking the other bits.
Overall, looks good 👍
|
Good suggestions, thanks! I'll make the |
4 tasks
jonty-uk-gov-mirror
pushed a commit
to uk-gov-mirror/DFE-Digital.claim-design-system
that referenced
this pull request
Apr 11, 2021
Make the Design System hostable with Heroku
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.