Add support for custom error pages #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sets up a custom 404 page and a generic error page which is used for all other 4xx and 5xx status codes. In order to allow for both config and the built site to be uploaded we: - add nginx config for error pages which will be included within the location block - modify middleman config to build into /deploy/public - add the new build directory to .gitignore - modify the CloudFoundry manifest to upload the entire /deploy/ directory - add a Staticfile configured to serve only /deploy/public and include the custom nginx config
alex-ju
approved these changes
Jul 4, 2017
|
Thanks for the review! |
|
Thanks for taking as though this PR Ollie, that was really helpful. To me the logic of it seems sound. |
jonty-uk-gov-mirror
pushed a commit
to uk-gov-mirror/DFE-Digital.claim-design-system
that referenced
this pull request
Apr 11, 2021
…error Fix JavaScript linting error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets up a custom 404 page and a generic error page which is used for all other 4xx and 5xx status codes.
In order to allow for both config and the built site to be uploaded we: