Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add small form controls #791

Merged
merged 5 commits into from
Apr 12, 2019
Merged

Add small form controls #791

merged 5 commits into from
Apr 12, 2019

Conversation

amyhupe
Copy link
Contributor

@amyhupe amyhupe commented Feb 7, 2019

No description provided.

@govuk-design-system-ci
Copy link
Collaborator

govuk-design-system-ci commented Feb 7, 2019

You can preview this change here:

Built with commit e72e355

https://deploy-preview-791--govuk-design-system-preview.netlify.com

@36degrees
Copy link
Contributor

Hints don't play well with smaller radios / checkboxes – because they're within the input wrapper they trigger the hover state, but clicking them doesn't actually activate the control.

I think we should probably add some guidance to not use hints with small form controls.

We should also consider whether there are other features we wouldn't expect people to use on smaller form controls – e.g. conditional reveals?

@amyhupe
Copy link
Contributor Author

amyhupe commented Apr 8, 2019

I've updated the guidance based on the working group's feedback. I have not included anything about hints @36degrees because @dashouse and I think it's unlikely people will try to do this and we don't want to unnecessarily bloat the guidance.

If we see evidence that people do or want to use hints with small form controls we will revisit this decision.

From my point of view this is ready now.

@aliuk2012
Copy link
Contributor

Once alphagov/govuk-frontend#1271 has been merged and v2.10.0 has been released. This PR can then be updated, reviewed and merged.

@aliuk2012 aliuk2012 changed the title [WORK IN PROGRESS - DNM] Add small form controls Add small form controls Apr 12, 2019
@aliuk2012 aliuk2012 merged commit 55eed38 into master Apr 12, 2019
@aliuk2012 aliuk2012 deleted the add-small-form-controls branch April 12, 2019 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants