-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add small form controls #791
Conversation
You can preview this change here: Built with commit e72e355 https://deploy-preview-791--govuk-design-system-preview.netlify.com |
277c5b9
to
1922613
Compare
Hints don't play well with smaller radios / checkboxes – because they're within the input wrapper they trigger the hover state, but clicking them doesn't actually activate the control. I think we should probably add some guidance to not use hints with small form controls. We should also consider whether there are other features we wouldn't expect people to use on smaller form controls – e.g. conditional reveals? |
I've updated the guidance based on the working group's feedback. I have not included anything about hints @36degrees because @dashouse and I think it's unlikely people will try to do this and we don't want to unnecessarily bloat the guidance. If we see evidence that people do or want to use hints with small form controls we will revisit this decision. From my point of view this is ready now. |
Once alphagov/govuk-frontend#1271 has been merged and v2.10.0 has been released. This PR can then be updated, reviewed and merged. |
Content edits to address [working group review feedback](alphagov/govuk-design-system-backlog#162 (comment))
Content edits following [working group review feedback](alphagov/govuk-design-system-backlog#162 (comment)).
4604e80
to
e72e355
Compare
No description provided.