Change Signon app to work with dart-sass #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I moved [1] the signon app from libsass to dart-sass following these instructions [2], I created a new `bin/dev` file which runs two processes in `Procfile.dev`, one of which runs the rails server and another which runs `dart-sass` in watch mode. This updates the `docker-compose.yml` file accordingly. [1]: alphagov/signon#2709 [2]: https://docs.publishing.service.gov.uk/manual/migrate-to-dart-sass-from-libsass.html
chrisroos
changed the title
chrisroos
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
I've tested this locally with the corresponding change in Signon and it all works as expecting 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I moved the signon app from libsass to dart-sass following these instructions, I created a new
bin/devfile which runs two processes inProcfile.dev, one of which runs the rails server and another which runsdart-sassin watch mode. This updates thedocker-compose.ymlfile accordingly.c.f. #714