Skip to content

Commit

Permalink
Set text colour for radios divider
Browse files Browse the repository at this point in the history
When testing component isolation on GOV.UK we noticed that text colour
isn't applied to a radios and instead it inherits this value.

I'm assuming this behaviour isn't intentional as all the neighbouring
fieldset components all have a colour set.
  • Loading branch information
kevindew committed Oct 5, 2018
1 parent f9b40e9 commit 22c9f44
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
10 changes: 7 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@

([PR #1007](https://github.com/alphagov/govuk-frontend/pull/1007))

- Set text colour for radios divider

([PR 1023](https://github.com/alphagov/govuk-frontend/pull/1023))

- Pull Request Title goes here

Description goes here (optional)
Expand All @@ -61,7 +65,7 @@
You can now pass additional attributes to links in header, footer, breadcrumbs, tabs and error-summary components

([PR #993](https://github.com/alphagov/govuk-frontend/pull/993))

- Fix issue with conditional form content and inline form controls

When inline variant of form controls is used with conditional content, we force
Expand Down Expand Up @@ -239,9 +243,9 @@
([PR #960](https://github.com/alphagov/govuk-frontend/pull/960))

- Use text colour on focus for better contrast

Updates the focus styles of links in GOV.UK Frontend so they pass WCAG contrast requirements.

([PR #982](https://github.com/alphagov/govuk-frontend/pull/982))

🆕 New features:
Expand Down
1 change: 1 addition & 0 deletions src/components/radios/_radios.scss
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,7 @@
.govuk-radios__divider {
$govuk-divider-size: $govuk-radios-size !default;
@include govuk-font($size: 19);
@include govuk-text-colour;
width: $govuk-divider-size;
margin-bottom: govuk-spacing(2);
text-align: center;
Expand Down

0 comments on commit 22c9f44

Please sign in to comment.