Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure test suite is run before releasing GOV.UK Frontend #493

Closed
NickColley opened this issue Feb 2, 2018 · 1 comment
Closed

Ensure test suite is run before releasing GOV.UK Frontend #493

NickColley opened this issue Feb 2, 2018 · 1 comment

Comments

@NickColley
Copy link
Contributor

At the moment it is possible to have a failing master branch.

  1. Contributor 1 pushes PR 1
  2. PR 1 passes CI
  3. Contributor 2 pushes PR 2 with breaking changes that 1 relied on
  4. PR 2 passes CI and is merged into master
  5. PR 1 will not now be failing since Travis only runs on updates to an individual PR, not master changes.

Considered solution: Force branches to be up-to-date with master

screen shot 2018-02-02 at 10 57 44

We ruled this out since it would mean with so many PRs happening we'd have to rebase very often which would slow down the team.

Another option is to ensure that before releases our test suite is ran.

We need to update the build scripts or documentation to include this step.

@36degrees
Copy link
Contributor

We ruled this out since it would mean with so many PRs happening we'd have to rebase very often which would slow down the team.

It would also provide an extra barrier to contribution in the future, as requiring contributors to continually rebase their PRs adds extra work to what should be a relatively simple process.

NickColley added a commit that referenced this issue May 22, 2018
There is a risk that master could contain code with bugs.
This commit ensures the test suite passes before pushing up the release to be merged.
Fixes #493
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants