You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We ruled this out since it would mean with so many PRs happening we'd have to rebase very often which would slow down the team.
It would also provide an extra barrier to contribution in the future, as requiring contributors to continually rebase their PRs adds extra work to what should be a relatively simple process.
There is a risk that master could contain code with bugs.
This commit ensures the test suite passes before pushing up the release to be merged.
Fixes#493
At the moment it is possible to have a failing master branch.
Considered solution: Force branches to be up-to-date with master
We ruled this out since it would mean with so many PRs happening we'd have to rebase very often which would slow down the team.
Another option is to ensure that before releases our test suite is ran.
We need to update the build scripts or documentation to include this step.
The text was updated successfully, but these errors were encountered: