Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set panel component's title heading level to 1 as default #864

Closed
kr8n3r opened this issue Jul 4, 2018 · 0 comments
Closed

Set panel component's title heading level to 1 as default #864

kr8n3r opened this issue Jul 4, 2018 · 0 comments
Labels
breaking change
Milestone
v2.0.0

Comments

@kr8n3r
Copy link

kr8n3r commented Jul 4, 2018

Default used to be h2, but in most cases it should be h1 with rare exceptions.
In #853 we made it customisable, while leaving the default as h2.

Setting h1 as default will be a breaking change
@kr8n3r kr8n3r added this to the v2.0.0 milestone Jul 4, 2018
NickColley added a commit to alphagov/govuk-design-system that referenced this issue Jul 13, 2018
@NickColley
Set panel component headingLevel to 1 in examples
25baa9f 
This reflects what the option will be when we make a breaking change in GOV.UK Frontend.
alphagov/govuk-frontend#864
@kr8n3r kr8n3r mentioned this issue Aug 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
1 participant
@kr8n3r