Fix IE8 in the dist/ compiled files
#1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1035
NickColley
force-pushed
the
dist-ie8-fix
branch
from
fd25eff
to
6fb0152
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1035
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1033
Since the files in
dist/are compressed, Uglify will break IE8 support by default.This pull request enables IE8 mode.
I'm not sure if there's a way we can ensure that this does not break in the future without some kind of dist test page.
We can hope that the Uglify project does not remove IE8 support without it silently failing.
I will leave it up for discussion if we need to do more to protect ourselves against that risk.
I have tested this by placing the built files in JSbin
Current build
Build generated from this PR
npm run build:dist